scwhittle commented on code in PR #35229:
URL: https://github.com/apache/beam/pull/35229#discussion_r2152118793
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/CoderTranslators.java:
##########
@@ -220,6 +224,44 @@ public List<? extends Coder<?>>
getComponents(NullableCoder<?> from) {
};
}
+ public static void overrideEncodingPositions(Schema schema) {
Review Comment:
should we instead make this a public method on SchemaTranslation? Then the
override wouldn't have to be public, it could be just done within
SchemaTranslation.schemaFromProto instead of requiring a separate method call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
