damccorm commented on code in PR #35297: URL: https://github.com/apache/beam/pull/35297#discussion_r2152843557
########## CHANGES.md: ########## @@ -76,7 +76,10 @@ ## Breaking Changes -* X behavior was changed ([#X](https://github.com/apache/beam/issues/X)). +* X behavior was changed ([#X](https://github.com/apache/beam/issues/X)).======= +* Yapf version upgraded to 0.43.0 for formatting (Python) ([#34801](https://github.com/apache/beam/pull/34801/)). +* Extra packages moved out of `install_required` to individual extra sections (`hdfs`, `mongodb`, `redis`) as part of [#35297](https://github.com/apache/beam/pull/35297) Review Comment: Could we mention that the others have been moved to separate (existing) extras as well? ########## sdks/python/setup.py: ########## @@ -391,10 +388,8 @@ def get_portability_package_data(): # 3. Exclude protobuf 4 versions that leak memory, see: # https://github.com/apache/beam/issues/28246 'protobuf>=3.20.3,<6.0.0.dev0,!=4.0.*,!=4.21.*,!=4.22.0,!=4.23.*,!=4.24.*', # pylint: disable=line-too-long - 'pydot>=1.2.0,<2', Review Comment: Looks like some of these are causing failures because the appropriate extras aren't installed when running the test - could you take a look? (or feel free to revert/simplify to a smaller set of dependencies) ########## sdks/python/setup.py: ########## @@ -391,10 +388,8 @@ def get_portability_package_data(): # 3. Exclude protobuf 4 versions that leak memory, see: # https://github.com/apache/beam/issues/28246 'protobuf>=3.20.3,<6.0.0.dev0,!=4.0.*,!=4.21.*,!=4.22.0,!=4.23.*,!=4.24.*', # pylint: disable=line-too-long - 'pydot>=1.2.0,<2', Review Comment: I see you started on this, I think its probably just adding interactive/yaml to a few tox suites -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
