kennknowles commented on code in PR #35180:
URL: https://github.com/apache/beam/pull/35180#discussion_r2152963123
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValue.java:
##########
@@ -57,4 +62,6 @@ default PaneInfo getPaneInfo() {
* value.
*/
<OtherT> WindowedValue<OtherT> withValue(OtherT value);
+
+ WindowedValue<T> withElementMetadata(@Nullable ElementMetadata
elementMetadata);
Review Comment:
We don't need this one - instead `OutputBuilder` will have
`setTracingContext` and similar methods and the builder will plumb it to the
constructor of the WindowedValue implementation.
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValue.java:
##########
@@ -34,6 +36,9 @@ public interface WindowedValue<T> {
/** The timestamp of this value in event time. */
Instant getTimestamp();
+ @Nullable
+ ElementMetadata getElementMetadata();
Review Comment:
I think now that this is user-facing it will not be in the interface like
this. Instead, the specific pieces of metadata will be in the interface and the
implementation(s) will return it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
