Abacn commented on code in PR #35085:
URL: https://github.com/apache/beam/pull/35085#discussion_r2162065687


##########
sdks/java/io/kafka/build.gradle:
##########
@@ -107,6 +107,9 @@ dependencies {
   testImplementation library.java.testcontainers_kafka
   testRuntimeOnly library.java.slf4j_jdk14
   testRuntimeOnly project(path: ":runners:direct-java", configuration: 
"shadow")
+  testImplementation project(path: ":runners:google-cloud-dataflow-java")

Review Comment:
   Consider a separate subproject. There is a potential circular dependency 
such that `:runners:google-cloud-dataflow-java` has compile time dependency on 
KafkaIO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to