Abacn commented on code in PR #35386:
URL: https://github.com/apache/beam/pull/35386#discussion_r2162461490
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -1226,8 +1226,6 @@ void connect() throws JMSException {
} else if (spec.getTopic() != null) {
this.destination = session.createTopic(spec.getTopic());
}
- // Create producer with null destination. Destination will be set
with producer.send().
Review Comment:
Honestly I'm not sure without dig into it and probably some testing. For
these legacy IOs I would prefer not touch code that has been working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
