lostluck commented on code in PR #35413:
URL: https://github.com/apache/beam/pull/35413#discussion_r2164961209
##########
sdks/go/pkg/beam/core/metrics/sampler.go:
##########
@@ -117,3 +129,11 @@ func getState(s bundleProcState) string {
return ""
}
}
+
+func getRestartLullTimeout() time.Duration {
+ userDefinedTimeout := jobopts.GetElementProcessingTimeout()
Review Comment:
I don't believe Flags are propagated to distributed workers, like for Google
Cloud Dataflow. This won't reliably set the value and trigger the value.
Consider looking at how the "harnessopts" uses hooks instead.
https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/util/harnessopts/sampler.go
There should be a flag, as you've got it to set the value for users, but it
needs to set a pipeline durable mechanism (like option hooks in harnessopts),
and access them appropriately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
