scwhittle commented on code in PR #35135:
URL: https://github.com/apache/beam/pull/35135#discussion_r2167596960
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ExecutionStateSampler.java:
##########
@@ -477,7 +477,7 @@ public void takeSample(long millisSinceLastSample) {
}
/** Updates the monitoring data for this {@link ExecutionState}. */
- public void updateMonitoringData(Map<String, ByteString> monitoringData)
{
+ public synchronized void updateMonitoringData(Map<String, ByteString>
monitoringData) {
Review Comment:
can you mark hasReportedValue and lastReportedValue with guardedby("this")
annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
