shunping commented on PR #35470: URL: https://github.com/apache/beam/pull/35470#issuecomment-3015994358
Looks like `SlowlyChangingSideInputsTest.test_side_input_slow_update` uses integer numbers in as start_timestamp and stop_timestamp when calling `PeriodicImpulse`. https://github.com/apache/beam/blob/4d58e6dbdbd9ee41b33fee432cb6a3c164f65266/sdks/python/apache_beam/examples/snippets/snippets_test.py#L1428 https://github.com/apache/beam/blob/4d58e6dbdbd9ee41b33fee432cb6a3c164f65266/sdks/python/apache_beam/examples/snippets/snippets_test.py#L1452-L1454 https://github.com/apache/beam/blob/4d58e6dbdbd9ee41b33fee432cb6a3c164f65266/sdks/python/apache_beam/examples/snippets/snippets.py#L1432-L1433. I suggest we support all `TimestampTypes` in PeriodicImpulse. https://github.com/apache/beam/blob/4d58e6dbdbd9ee41b33fee432cb6a3c164f65266/sdks/python/apache_beam/utils/timestamp.py#L39 @damccorm, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
