nhonx opened a new issue, #35474:
URL: https://github.com/apache/beam/issues/35474

   ### What happened?
   
   In `beam/sdks/python/apache_beam/io/gcp/gcsio_test.py:FakeBucket`, there is 
a small typo missing:
   ```python
   def _create_blob(self, name):
       return FakeBlob(name, self)
   #....
   def lookup_blob(self, name):
       bucket = self._get_canonical_bucket()
       if name in bucket.blobs:
         return bucket.blobs[name]
       else:
         return bucket.create_blob(name) # Should be bucket._create_blob(name)
   ```
   
   Also, `lookup_blob` should return a blob in current bucket, so in the case 
blob name doesn't exist, we should `_create_blob` and add it to bucket instance 
before returning it.
   
   ### Issue Priority
   
   Priority: 2 (default / most bugs should be filed as P2)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [ ] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [ ] Component: IO connector
   - [ ] Component: Beam YAML
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Infrastructure
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to