liferoad opened a new pull request, #35476:
URL: https://github.com/apache/beam/pull/35476

   The TextTableProvider was failing with a NullPointerException when using the 
JSON format on java 17:
   
   ```
   > Task :sdks:java:extensions:sql:test
   
   org.apache.beam.sdk.extensions.sql.meta.provider.text.TextTableProviderTest 
> testJson FAILED
       org.apache.beam.sdk.extensions.sql.impl.ParseException at 
TextTableProviderTest.java:224
           Caused by: 
org.apache.beam.vendor.calcite.v1_28_0.org.apache.calcite.tools.ValidationException
 at TextTableProviderTest.java:224
               Caused by: java.lang.NullPointerException at 
TextTableProviderTest.java:224
   
   org.apache.beam.sdk.extensions.sql.meta.provider.text.TextTableProviderTest 
> testWriteJson FAILED
       org.apache.beam.sdk.extensions.sql.impl.ParseException at 
TextTableProviderTest.java:305
           Caused by: 
org.apache.beam.vendor.calcite.v1_28_0.org.apache.calcite.tools.ValidationException
 at TextTableProviderTest.java:305
               Caused by: java.lang.NullPointerException at 
TextTableProviderTest.java:305
   ```
   
   Overriding the `buildIOWriter` method in `TextJsonTable` to correctly handle 
writing JSON files.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable. This will automatically add a link to the 
pull request in the issue. If you would like the issue to automatically close 
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit 
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   
------------------------------------------------------------------------------------------------
   [![Build python source distribution and 
wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python 
tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java 
tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go 
tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more 
information about GitHub Actions CI or the [workflows 
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) 
to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to