flo076 commented on code in PR #35472:
URL: https://github.com/apache/beam/pull/35472#discussion_r2175225066


##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlPipelineOptions.java:
##########
@@ -30,6 +30,11 @@ public interface BeamSqlPipelineOptions extends 
PipelineOptions {
 
   void setPlannerName(String className);
 
+  @Description("The dialect of calcite connection.")
+  String getCalciteConnectionDialect();
+
+  void setCalciteConnectionDialect(String dialect);
+

Review Comment:
   ```suggestion
      @Description("The properties of calcite connection. For example 
<('fun','bigquery'), ('lex','big_query')>")
     Map<String,String> getCalciteConnectionProperties()
     
     void setCalciteConnectionProperties(Map<String,String> dialect);
     
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to