Abacn commented on code in PR #35551:
URL: https://github.com/apache/beam/pull/35551#discussion_r2197895116


##########
sdks/java/javadoc/build.gradle:
##########
@@ -83,4 +81,22 @@ task aggregateJavadoc(type: Javadoc) {
       links createJavadocIOUrlForDependency(dep)
     }
   }
+
+  // certain projects need generated sources for javadoc generation
+  // Part of flink sources came from custom copySourceOverrides target
+  dependsOn 
":runners:flink:${flink_versions.split(",").first()}:copySourceOverrides"
+  // Auto value class appeared in class annotation (jackson)
+  dependsOn ':sdks:java:io:solace:compileJava'
+  source 
project(':sdks:java:io:solace').layout.buildDirectory.dir('generated/sources/annotationProcessor/java/main')
+  dependsOn ':sdks:java:io:amazon-web-services2:compileJava'
+  source 
project(':sdks:java:io:amazon-web-services2').layout.buildDirectory.dir('generated/sources/annotationProcessor/java/main')
+
+  doLast {
+    File myFile = new 
File(layout.buildDirectory.dir("docs/javadoc/index.html").get().toString())

Review Comment:
   I observe that when `aggregateJavadoc` executed (not "from cache"), the 
javadoc/ dir first get cleaned up, with all previous files deleted. The 
directory remains empty until  the target nearly ends (all files propagated 
within 1 second). This explains if javadoc failed early no file gets written at 
all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to