liferoad commented on code in PR #35567:
URL: https://github.com/apache/beam/pull/35567#discussion_r2203475505


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -1155,16 +1158,36 @@ <T> long insertAll(
                     .setErrors(ImmutableList.of(new 
ErrorProto().setReason("row-too-large")));
             // We verify whether the retryPolicy parameter expects us to 
retry. If it does, then
             // it will return true. Otherwise it will return false.
-            Boolean isRetry = retryPolicy.shouldRetry(new 
InsertRetryPolicy.Context(error));
-            if (isRetry) {
+            if (retryPolicy.shouldRetry(new InsertRetryPolicy.Context(error))) 
{
+              // Create row details composed of key value pairs.
+              String rowDetails;

Review Comment:
   Does logging the row details help resolve 
https://github.com/apache/beam/issues/35566 since it mentions the underlying 
schema is actually wrong? I think we should somehow surface the schema issue 
here, right?
   
   And in general, we do not want to log the raw rows since the data could be 
sensitive.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to