Abacn commented on code in PR #35575:
URL: https://github.com/apache/beam/pull/35575#discussion_r2204874030
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -1507,7 +1507,9 @@ public void close() throws Exception {
@Override
public void pin() {
synchronized (this) {
- Preconditions.checkState(!closed);
Review Comment:
Can we confirm it is safe to silent pin? It doesn't look right to me. I
understand after pin the thread leases the client and is going to write. Write
on an invalid client will just delay the error to later stage. In general one
should fix the cause of the race than skip checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
