damccorm commented on code in PR #35585:
URL: https://github.com/apache/beam/pull/35585#discussion_r2205562207
##########
.github/workflows/beam_PostCommit_Python.yml:
##########
@@ -54,14 +54,15 @@ env:
jobs:
beam_PostCommit_Python:
name: ${{ matrix.job_name }} (${{ matrix.job_phrase }} ${{
matrix.python_version }})
- runs-on: [self-hosted, ubuntu-20.04, highmem22]
+ runs-on: ${{ matrix.os }}
timeout-minutes: 240
strategy:
fail-fast: false
matrix:
job_name: [beam_PostCommit_Python]
job_phrase: [Run Python PostCommit]
python_version: ['3.9', '3.10', '3.11', '3.12']
+ os: [[self-hosted, ubuntu-20.04, highmem22], [ubuntu-latest]]
Review Comment:
Could you add a small comment that describes why we're doing this here and
in the other workflow?
##########
sdks/python/pytest.ini:
##########
@@ -70,6 +70,7 @@ markers =
uses_mock_api: tests that uses the mock API cluster.
uses_feast: tests that uses feast in some way
gemini_postcommit: gemini postcommits that need additional deps.
+ require_non_self_hosted: tests requiring specialized environments or
infrastructure not present in self-hosted setups.
Review Comment:
```suggestion
require_non_self_hosted: tests which can't be run on Beam's self hosted
GitHub Actions runners. Usually this is because of issues with docker-in-docker
or other environmental challenges. Context:
https://github.com/apache/beam/pull/35585
```
It would help to have more info here, feel free to use different wording
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
