tvalentyn commented on code in PR #35569:
URL: https://github.com/apache/beam/pull/35569#discussion_r2205591029
##########
sdks/python/apache_beam/transforms/periodicsequence.py:
##########
@@ -301,21 +302,37 @@ def __init__(
sufficient to cover the duration defined by `start_timestamp`,
`stop_timestamp`, and `fire_interval`; otherwise, a `ValueError` is
raised.
+
+ :param rebase_timestamp: Whether to shift the generated timestamps to begin
Review Comment:
let's name this `rebase_timestamps` if you go with this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
