Abacn commented on code in PR #35582:
URL: https://github.com/apache/beam/pull/35582#discussion_r2205943281
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/parquet/ParquetTable.java:
##########
@@ -122,4 +124,11 @@ public IsBounded isBounded() {
public ProjectSupport supportsProjects() {
return ProjectSupport.WITH_FIELD_REORDERING;
}
+
+ private String resolveFilePattern(String location) {
+ if (location.endsWith("/")) {
Review Comment:
Previously user can provide a directory without trailing "/", now the
runtime FileSystems.match() will resolve to not found or a directory (depending
on filesystem type), we may mention this breaking change in CHANGES.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
