ahmedabu98 commented on code in PR #35526:
URL: https://github.com/apache/beam/pull/35526#discussion_r2213318120


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryWriteConfiguration.java:
##########
@@ -194,6 +194,9 @@ public static Builder builder() {
           + "Is mutually exclusive with 'keep' and 'drop'.")
   public abstract @Nullable String getOnly();
 
+  @SchemaFieldDescription("A list of columns to cluster the BigQuery table 
by.")
+  public abstract @Nullable List<String> getClustering();

Review Comment:
   nit: what do you think of the name `getClusteringFields()`?
   
   Was mainly thinking about the generated parameter name for ManagedIO and 
Xlang: `clustering` vs `clustering_fields`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to