lukecwik commented on a change in pull request #12637:
URL: https://github.com/apache/beam/pull/12637#discussion_r487190235
##########
File path: sdks/python/apache_beam/runners/worker/data_plane_test.py
##########
@@ -99,35 +100,33 @@ def send(instruction_id, transform_id, data):
# Single write.
send('0', transform_1, b'abc')
- self.assertEqual(
+ hc.assert_that(
Review comment:
Yes, the stream should be created outside of send so that its lifetime
can be explicitly managed in the test based upon what the test is trying to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
