shunping commented on code in PR #35253:
URL: https://github.com/apache/beam/pull/35253#discussion_r2234139861
##########
sdks/python/apache_beam/io/filebasedsink.py:
##########
@@ -385,13 +431,131 @@ def _rename_batch(batch):
# This error is not serious, we simply log it.
_LOGGER.info('Unable to delete file: %s', init_result)
+ @check_accessible(['file_path_prefix'])
+ def finalize_windowed_write(
Review Comment:
Since `finalize_windowed_write()` is mostly identical to `finalize_write()`,
except for the new window parameter, can we make `finlaize_write()` call
`finalize_windowed_write()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
