damccorm commented on code in PR #35733: URL: https://github.com/apache/beam/pull/35733#discussion_r2242758226
########## sdks/python/scripts/run_pytest.sh: ########## @@ -62,16 +81,60 @@ if [[ -n $user_marker ]]; then marker_for_sequential_tests="($user_marker) and ($marker_for_sequential_tests)" fi +# Parse posargs to separate pytest options from test paths. +options="" +test_paths="" + +# Safely split the posargs string into individual arguments. +eval "set -- $posargs" Review Comment: I think we don't need to worry about this. We're directly invoking this script and control what arguments are passed in. If anyone invokes this script, they already have full permissions to run arbitrary code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
