derrickaw commented on code in PR #35745:
URL: https://github.com/apache/beam/pull/35745#discussion_r2243910148
##########
sdks/python/apache_beam/yaml/yaml_ml.py:
##########
@@ -50,11 +50,11 @@ def _list_submodules(package):
from apache_beam.ml.transforms import tft
from apache_beam.ml.transforms.base import MLTransform
# TODO(robertwb): Is this all of them?
- _transform_constructors = {}
except ImportError:
tft = None # type: ignore
Review Comment:
A valueerror is already covering this.
##########
sdks/python/apache_beam/yaml/yaml_ml.py:
##########
@@ -50,11 +50,11 @@ def _list_submodules(package):
from apache_beam.ml.transforms import tft
from apache_beam.ml.transforms.base import MLTransform
# TODO(robertwb): Is this all of them?
- _transform_constructors = {}
except ImportError:
tft = None # type: ignore
Review Comment:
A valueerror is already covering this further down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
