tvalentyn commented on pull request #12811: URL: https://github.com/apache/beam/pull/12811#issuecomment-691312707
Thanks a lot, @samatix ! Overall the change looks good. There is a linter error: ``` 09:40:28 apache_beam/runners/portability/stager_test.py:451:0: C0301: Line too long (81/80) (line-too-long) ``` Also, we will need to Drop Py2 and Py35 support before we can merge this (Py2, Py 3.5.2 tests are failing on this change right now). This should happen before next release. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
