Abacn commented on code in PR #35621:
URL: https://github.com/apache/beam/pull/35621#discussion_r2260786674
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java:
##########
@@ -276,8 +276,8 @@ public static void main(
IdGenerator idGenerator = IdGenerators.decrementingLongs();
ShortIdMap metricsShortIds = new ShortIdMap();
- ExecutorService executorService =
Review Comment:
Oh racing condition comment. This attracted attention at first glance
because there was a thread leak bug due to Executor created every time spin up
a runner - #32272 . As long as shutdown is called when Executor no longer used
I think it's fine. Thanks again for the details!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
