damccorm commented on code in PR #35809:
URL: https://github.com/apache/beam/pull/35809#discussion_r2266879620
##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -459,7 +459,7 @@ def vllmTests = tasks.create("vllmTests") {
// TODO(https://github.com/apache/beam/issues/22651): Build docker image
for VLLM tests during Run time.
// This would also enable to use wheel "--sdk_location" as other tasks,
and eliminate distTarBall dependency
// declaration for this project.
- // Right now, this is built from
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/ml/inference/test_resources/vllm.dockerfile
+ // Right now, this is built from
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/ml/inference/test_resources/vllm.dockerfile.old
Review Comment:
Could we just point this at the new image? Then we can also get rid of the
old docker file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
