shunping commented on code in PR #35849:
URL: https://github.com/apache/beam/pull/35849#discussion_r2268445147
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -1531,12 +1531,15 @@ def _join_url_or_filepath(base, path):
return path
base_scheme = urllib.parse.urlparse(base, '').scheme
path_scheme = urllib.parse.urlparse(path, base_scheme).scheme
- if path_scheme != base_scheme:
+ if path_scheme != base_scheme or path.startswith(path_scheme + "://"):
+ # path has its own scheme or path is an absolute path
return path
- elif base_scheme and base_scheme in urllib.parse.uses_relative:
- return urllib.parse.urljoin(base, path)
else:
- return FileSystems.join(FileSystems.split(base)[0], path)
+ # path is a relative path
+ if base_scheme and base_scheme in urllib.parse.uses_relative:
+ return urllib.parse.urljoin(base, path)
+ else:
+ return FileSystems.join(FileSystems.split(base)[0], path)
Review Comment:
outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
