Abacn commented on code in PR #35757:
URL: https://github.com/apache/beam/pull/35757#discussion_r2270079275
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -1180,18 +1180,18 @@ private HandlesSplits.SplitResult
trySplitForElementAndRestriction(
splitResult.getWindowSplit(),
PTransformTranslation.SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS_URN
+ "/GetSize");
+ Coder fullInputCoder = WindowedValues.getFullCoder(inputCoder,
windowCoder);
+ return constructSplitResult(
+ windowedSplitResult,
+ null,
+ fullInputCoder,
+ initialWatermark,
+ watermarkAndState,
+ pTransformId,
+ mainInputId,
+ pTransform.getOutputsMap().keySet(),
+ resumeDelay);
}
Review Comment:
split shouldn't be frequent. Close for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
