Abacn commented on code in PR #35822:
URL: https://github.com/apache/beam/pull/35822#discussion_r2274135462
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TwoLevelMessageConverterCache.java:
##########
@@ -71,4 +72,8 @@ public MessageConverter<ElementT> get(
KV.of(operationName, destination),
Review Comment:
Or should the key of cache to be KV<String, DestinationT> as well (sharded
keys then share an append client)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
