Abacn commented on code in PR #35946:
URL: https://github.com/apache/beam/pull/35946#discussion_r2301368369
##########
sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbGridFSIO.java:
##########
@@ -331,12 +344,18 @@ public void teardown() {
@ProcessElement
public void processElement(final ProcessContext c)
throws IOException {
- Preconditions.checkStateNotNull(gridfs);
+ GridFSBucket bucket =
Preconditions.checkStateNotNull(gridFSBucket);
ObjectId oid = c.element();
- GridFSDBFile file = gridfs.find(oid);
+ GridFSDownloadStream downloadStream =
bucket.openDownloadStream(oid);
+ GridFSFile gridFSFile =
+
bucket.find(com.mongodb.client.model.Filters.eq("_id", oid)).first();
+ if (gridFSFile == null) {
Review Comment:
Is it fine to early return if not found?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
