lostluck commented on code in PR #35964:
URL: https://github.com/apache/beam/pull/35964#discussion_r2302337756
##########
sdks/go/pkg/beam/runners/prism/internal/environments.go:
##########
@@ -273,19 +275,21 @@ func dockerEnvironment(ctx context.Context, logger
*slog.Logger, dp *pipepb.Dock
rc, err := cli.ContainerLogs(bgctx, containerID,
container.LogsOptions{Details: true, ShowStdout: true, ShowStderr: true})
if err != nil {
logger.Error("docker container logs error",
"error", err)
+ } else {
Review Comment:
Just return after the error case instead of having the else block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
