kennknowles commented on code in PR #35684:
URL: https://github.com/apache/beam/pull/35684#discussion_r2311143031
##########
examples/java/src/main/java/org/apache/beam/examples/complete/StreamingWordExtract.java:
##########
@@ -123,13 +123,11 @@ public static void main(String[] args) throws IOException
{
Pipeline pipeline = Pipeline.create(options);
String tableSpec =
- new StringBuilder()
- .append(options.getProject())
- .append(":")
- .append(options.getBigQueryDataset())
- .append(".")
- .append(options.getBigQueryTable())
- .toString();
+ options.getProject()
Review Comment:
Do we not like StringBuilder any more?
##########
it/google-cloud-platform/src/test/java/org/apache/beam/it/gcp/bigquery/BigQueryStreamingLT.java:
##########
@@ -132,7 +132,7 @@ public void setUpTest() {
String expectedTable =
TestProperties.getProperty("expectedTable", "",
TestProperties.Type.PROPERTY);
if (!Strings.isNullOrEmpty(expectedTable)) {
- config.toBuilder().setExpectedTable(expectedTable).build();
+ config = config.toBuilder().setExpectedTable(expectedTable).build();
Review Comment:
wow...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
