charlespnh commented on code in PR #36012:
URL: https://github.com/apache/beam/pull/36012#discussion_r2314612774


##########
sdks/python/apache_beam/yaml/examples/transforms/ml/fraud_detection/fraud_detection_mlops_beam_yaml_sdk.ipynb:
##########
@@ -0,0 +1,1329 @@
+{
+ "cells": [
+  {
+   "cell_type": "code",
+   "source": [
+    "# @title ###### Licensed to the Apache Software Foundation (ASF), Version 
2.0 (the \"License\")\n",

Review Comment:
   > Is it possible to add the YAML pipeline as a separate file as well with 
instructions for running similar to other examples ?
   
   I've given a lot of thought about this: The workflow is pretty complex with 
model training and several pipelines and custom transforms. I thought it makes 
more sense to place all these parts in a notebook so people can follow the 
example easily.
   Otherwise if the pipelines and model training are in separate files then a 
bash script is needed to tie them together into a workflow, and it wouldn't 
have a nice flow of explanation that a notebook can have.
   
   > That will be more convenient for someone whose looking to try/modify this 
example with different runners etc.
   
   User can still modify the example and try out with different runners inside 
this notebook.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to