liferoad commented on code in PR #36001:
URL: https://github.com/apache/beam/pull/36001#discussion_r2314205396
##########
sdks/python/apache_beam/runners/direct/direct_runner.py:
##########
@@ -202,9 +201,17 @@ def visit_transform(self, applied_ptransform):
# Use BundleBasedDirectRunner if other runners are missing needed features.
runner = BundleBasedDirectRunner()
+ # Check if transform overrides are needed - if so,
+ # use BundleBasedDirectRunner
+ # since Prism does not support transform overrides
+ transform_overrides = _get_transform_overrides(options)
+ if transform_overrides:
Review Comment:
My PR makes sure only minimal changes are introduced without breaking any
potential update compatibility. This is why I overrides the batch
implementation instead of touching any streaming part.
https://github.com/apache/beam/blob/17d5039a02f14b2abfb7dff664dcfe6293117629/sdks/python/apache_beam/io/gcp/pubsub.py#L438:
are you sure we can easily change this based on the Java implementation? or
is it worth matching the Java one given this issue has been existing for a
while and my current PR (not perfect) solves this for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
