shunping commented on code in PR #36014:
URL: https://github.com/apache/beam/pull/36014#discussion_r2319163872
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -690,7 +690,16 @@ def add(self, urn, logical_type):
self.by_language_type[logical_type.language_type()] = logical_type
def get_logical_type_by_urn(self, urn):
- return self.by_urn.get(urn, None)
+ logical_type = self.by_urn.get(urn, None)
Review Comment:
The import here is for importing classes and logical type registration. We
need the those classes to be imported first.
Also, we cannot put the import at the beginning of schemas.py due to
circular dependency.
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -690,7 +690,16 @@ def add(self, urn, logical_type):
self.by_language_type[logical_type.language_type()] = logical_type
def get_logical_type_by_urn(self, urn):
- return self.by_urn.get(urn, None)
+ logical_type = self.by_urn.get(urn, None)
Review Comment:
The import here is for importing classes and logical type registration. We
need those classes to be imported first.
Also, we cannot put the import at the beginning of schemas.py due to
circular dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
