fozzie15 commented on code in PR #35644:
URL: https://github.com/apache/beam/pull/35644#discussion_r2325889534
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaWriteSchemaTransformProvider.java:
##########
@@ -161,13 +168,58 @@ public void finish() {
}
}
+ public static class RecordErrorCounterFn extends DoFn<Row, KV<byte[],
GenericRecord>> {
Review Comment:
Agreed, I was going to wait and refactor this in the future but I was able
to get this changed quickly due to prior art on Kerberos. I tested this with
the same pipelines as the original classes and it passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
