sjvanrossum commented on PR #36075:
URL: https://github.com/apache/beam/pull/36075#issuecomment-3263676325

   > Note for reviewers, I'm aware of Guava's 
`Suppliers.memoizeWithExpiration(...)`. Guava's expiry mechanism refreshes by 
locking and having all observers wait on the newly supplied value. The expiry 
mechanism extracted from `KafkaLatestOffsetEstimator` refreshes by claiming the 
expiration timestamp's low bit and returning the current value to other 
observers until the claim holding observer's newly supplied value is made 
visible by progressing the expiration timestamp by one period with the claim 
bit unset.
   
   Renaming the class to `WeakExpiringMemoizingSerializableSupplier` 
(`FashionablyLateExpiringMemoizingSerializableSupplier`?) might help to convey 
that difference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to