ian-Liaozy opened a new pull request, #36089:
URL: https://github.com/apache/beam/pull/36089
Fixes #36088
** Description:**
This PR addresses an issue where resource hints, particularly `tags`, are
not correctly propagated when using the `with_exception_handling()` method on a
`ParDo` transform.
Currently, any resource hints applied via `.with_resource_hints()` are lost
when `with_exception_handling()` wraps the transform. The hints are not passed
from the original `ParDo` to the `_ExceptionHandlingWrapper`, and subsequently
not to the inner `ParDo` created within the wrapper's `expand` method. This
prevents effective control over stage fusion, which is critical for pipelines
utilizing accelerators like TPUs.
**Fix:**
This PR implements the following changes:
1. Modified `ParDo.with_exception_handling` to copy resource hints from the
`ParDo` instance to the created `_ExceptionHandlingWrapper` instance.
2. Modified `_ExceptionHandlingWrapper.expand` to copy resource hints from
the wrapper to the inner `beam.ParDo` instance it constructs.
These changes ensure that resource hints are preserved across the
`with_exception_handling` boundary.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
