stankiewicz commented on code in PR #34902:
URL: https://github.com/apache/beam/pull/34902#discussion_r2360493581


##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -1960,8 +1975,7 @@ public void outputWindowedValue(
         Instant timestamp,
         Collection<? extends BoundedWindow> windows,
         PaneInfo paneInfo) {
-      checkTimestamp(timestamp);
-      outputTo(mainOutputConsumer, WindowedValues.of(output, timestamp, 
windows, paneInfo));
+      
builder(output).setTimestamp(timestamp).setWindows(windows).setPaneInfo(paneInfo).output();

Review Comment:
   I just like it so much!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to