damccorm commented on code in PR #36172: URL: https://github.com/apache/beam/pull/36172#discussion_r2360784895
########## sdks/python/apache_beam/examples/inference/vertex_ai_llm_text_classification.py: ########## @@ -21,6 +21,15 @@ model can be generated by fine tuning the text-bison model or another similar model (see https://cloud.google.com/vertex-ai/docs/generative-ai/models/tune-models#supervised-fine-tuning) + +**NOTE** +Google has deprecated non-Gemini LLMs and no longer supports querying them on +Vertex AI endpoints. Separately, the use of the Vertex AI Predict API is not +supported for Gemini models in favor of use of the google-genai API. As a +result, this example no longer works. To perform inference with remote LLMs +deployed on Google infrastructure, please see the `GeminiModelHandler` +(in `apache_beam.ml.inference.gemini_inference`) and the +`gemini_text_classification.py` example. Review Comment: Should we update https://github.com/apache/beam/tree/f27eec717b9b7e78954f97cae7bda8680382bd91/sdks/python/apache_beam/examples/inference#text-classifcation-with-a-vertex-ai-llm ? Also, I assume this would still work if you deployed your own LLM, right, its just generally not the path we'd recommend? Overall, the change looks good but we probably want to update the readme and soften the language a little bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
