mohamedawnallah commented on PR #35816: URL: https://github.com/apache/beam/pull/35816#issuecomment-3275583993
> Regards milvus tests they aren't supposed to running on postcommit python workflow given they are already marked with `require_docker_in_docker` and excluded to run in this workflow since we have removed `ubuntu-latest`: > > https://github.com/apache/beam/blob/10f0f07283410438ed016f5d2606f2d5b2a0a022/sdks/python/apache_beam/ml/rag/enrichment/milvus_search_it_test.py#L472-L480 > > https://github.com/apache/beam/blob/10f0f07283410438ed016f5d2606f2d5b2a0a022/.github/workflows/beam_PostCommit_Python.yml#L109-L113 @damccormy you are right. Milvus tests failure turned actually to be real problem. It turns out the issue forgetting removing `dockerInDockerIntegrationTest` from the test-suites gradle file (so they were triggered on postcommit given no ubuntu-latest though). With this commit cc9f74c4d793a27f5b9f3434213202b0dbd4c812 this issue would be addressed Regards CloudSQL tests given that PR #35473 is merged (also merged the latest changes here). They are expected not to run in the postcommits so no issues supposed to happen regards them in PostCommit python workflow Can we trigger the workflows again (similar to https://github.com/apache/beam/pull/35816#issuecomment-3266488441) with those changes to make sure no regressions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
