shunping commented on code in PR #36142:
URL: https://github.com/apache/beam/pull/36142#discussion_r2353974166
##########
sdks/go/test/integration/primitives/windowinto.go:
##########
@@ -214,7 +214,7 @@ func TriggerElementCount(s beam.Scope) {
validateCount(s.Scope("Fixed"), window.NewFixedWindows(windowSize), col,
[]beam.WindowIntoOption{
beam.Trigger(trigger.AfterCount(2)),
- }, 2)
+ }, 1)
Review Comment:
The count here is one, because the output only contains one aggregated
element for window [0, 10000], which is the sum of 1.0 and 2.0.
- `AfterCount` is going to be repeatedly applied.
- No on-time pane fired at the end of window.
- For window [50000, 60000], there is one one element so the trigger is not
fired either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
