shunping commented on code in PR #36242:
URL: https://github.com/apache/beam/pull/36242#discussion_r2371059764
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -569,36 +603,7 @@ func (em *ElementManager) checkForQuiescence(advanced
set[string]) error {
// Jobs must never get stuck so this indicates a bug in prism to be
investigated.
slog.Debug("Bundles: nothing in progress and no refreshes",
slog.Int64("pendingElementCount", v))
- var stageState []string
Review Comment:
The code here is moved to a separate function that can be called in other
places.
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -569,36 +603,7 @@ func (em *ElementManager) checkForQuiescence(advanced
set[string]) error {
// Jobs must never get stuck so this indicates a bug in prism to be
investigated.
slog.Debug("Bundles: nothing in progress and no refreshes",
slog.Int64("pendingElementCount", v))
- var stageState []string
Review Comment:
The code here has been moved to a separate function that can be called in
other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
