Abacn commented on code in PR #36254:
URL: https://github.com/apache/beam/pull/36254#discussion_r2373868821
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/testing/TestPipeline.java:
##########
@@ -511,6 +525,27 @@ public TestPipeline enableAutoRunIfMissing(final boolean
enable) {
return this;
}
+ /**
+ * Detects if we're running in a JUnit 5 context by checking the stack trace
for
+ * TestPipelineExtension. This is used to provide JUnit 5 compatibility
without breaking JUnit 4
+ * behavior.
+ */
+ private boolean isJUnit5Context() {
Review Comment:
This looks like an ad-hoc fix. There should be a cleaner way to do this
(than bump stack trace and check class name). Let me also do some experiments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
