damccorm commented on code in PR #36184:
URL: https://github.com/apache/beam/pull/36184#discussion_r2380108068
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -4081,6 +4081,8 @@ def expand(self, pbegin):
# transforms (e.g. Write).
class MaybeReshuffle(PTransform):
+ side_inputs = ()
Review Comment:
> Do we also want to add a label for this change too?
I think we should do this and deal with the one-time update compat change. I
don't think we can be in a place where we can't update this (pretty important)
file
We can document this in CHANGES.md and give people a clear update path (via
transform_name_mapping)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
