Abacn commented on code in PR #36121:
URL: https://github.com/apache/beam/pull/36121#discussion_r2392073157
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -552,8 +552,14 @@ def typing_from_runner_api(
if fieldtype_proto.logical_type.urn == PYTHON_ANY_URN:
return Any
else:
- return LogicalType.from_runner_api(
- fieldtype_proto.logical_type).language_type()
+ logical_type_instance = LogicalType.from_runner_api(
+ fieldtype_proto.logical_type)
+ # Special case for GeographyType: return the logical type class itself
Review Comment:
We shouldn't need special case. geography is just a normal pass-through
logical type backed by str. Moreover I doubt that
"beam:logical_type:geography:v1" is used at all. If it is used by BQIO it would
need Java side change. Likely Java BQIO just treat GEOGRAPHY as String, and
BigQuery client also accepts String for GEOGRAPHY columns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
