tvalentyn commented on code in PR #36345:
URL: https://github.com/apache/beam/pull/36345#discussion_r2395447247
##########
sdks/python/apache_beam/coders/coders_test_common.py:
##########
@@ -248,12 +249,13 @@ def test_memoizing_pickle_coder(self):
@parameterized.expand([
param(compat_version=None),
param(compat_version="2.67.0"),
+ param(compat_version="2.68.0"),
Review Comment:
Could you please call out somewhere in a comment notable behavior
differences in 2.67.0, 2.68.0 that are relevant for this test scenario?
##########
sdks/python/apache_beam/coders/coder_impl.py:
##########
@@ -377,12 +378,14 @@ def __init__(
self,
fallback_coder_impl,
requires_deterministic_step_label=None,
- force_use_dill=False):
+ force_use_dill=False,
+ skip_use_relative_filepaths=False):
Review Comment:
in general, i try to avoid double-negations. would it make sense to use
`use_relative_filepaths=True` instead?
##########
sdks/python/apache_beam/coders/coders_test_common.py:
##########
@@ -799,6 +805,17 @@ def run_subprocess():
logging.warning("Could not decode %s data due to %s", test_name, e)
continue
+ if test_name == "named_tuple_simple" and not is_using_dill:
+ should_have_relative_path = not compat_version
Review Comment:
could you add a comment explaining why `should_have_relative_path = not
compat_version`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
