shunping commented on code in PR #36285:
URL: https://github.com/apache/beam/pull/36285#discussion_r2398882063
##########
sdks/python/apache_beam/transforms/trigger.py:
##########
@@ -933,6 +980,13 @@ def to_runner_api(self, context):
def has_ontime_pane(self):
return any(t.has_ontime_pane() for t in self.triggers)
+ def get_continuation_trigger(self):
+ return Repeatedly(
Review Comment:
Could you explain why the continuation trigger of a AfterEach trigger is a
repeatedly trigger?
##########
sdks/python/apache_beam/transforms/trigger.py:
##########
@@ -933,6 +980,13 @@ def to_runner_api(self, context):
def has_ontime_pane(self):
return any(t.has_ontime_pane() for t in self.triggers)
+ def get_continuation_trigger(self):
+ return Repeatedly(
Review Comment:
Could you explain why the continuation trigger of a AfterEach trigger is a
repeatedly trigger? @tarun-google
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
