damccorm commented on code in PR #36453:
URL: https://github.com/apache/beam/pull/36453#discussion_r2426416013


##########
sdks/python/apache_beam/io/gcp/bigquery_file_loads_test.py:
##########
@@ -411,13 +406,6 @@ def test_partition_files_dofn_size_split(self):
           label='CheckSinglePartition')
 
 
-def maybe_skip(compat_version):

Review Comment:
   ```
   self = <apache_beam.io.gcp.bigquery_file_loads_test.TestBigQueryFileLoads 
testMethod=test_triggering_frequency_3>
   is_streaming = True, with_auto_sharding = False, compat_version = '2.64.0'
   
       @parameterized.expand([
           param(is_streaming=False, with_auto_sharding=False, 
compat_version=None),
           param(is_streaming=True, with_auto_sharding=False, 
compat_version=None),
           param(is_streaming=True, with_auto_sharding=True, 
compat_version=None),
           param(
               is_streaming=True, with_auto_sharding=False, 
compat_version="2.64.0"),
           param(
               is_streaming=True, with_auto_sharding=True, 
compat_version="2.64.0"),
       ])
       def test_triggering_frequency(
           self, is_streaming, with_auto_sharding, compat_version):
   >     maybe_skip(compat_version)
   E     NameError: name 'maybe_skip' is not defined
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to