parveensania commented on code in PR #35901:
URL: https://github.com/apache/beam/pull/35901#discussion_r2377129413
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/SingleSourceWorkerHarness.java:
##########
@@ -66,6 +67,7 @@ public final class SingleSourceWorkerHarness implements
StreamingWorkerHarness {
private final Function<String, Optional<ComputationState>>
computationStateFetcher;
private final ExecutorService workProviderExecutor;
private final GetWorkSender getWorkSender;
+ @Nullable private WindmillStream.GetWorkStream getWorkStream;
Review Comment:
I think it is likely not needed. The dispatch loop is run by
workProviderExecutor which is a SingleThreadExecutor. So access to
getWorkStream should be sequential. In the shutdown(), before shutting down
getWorkStream, we shutdown workProviderExecutor first and that's the only
place where getWorkStream is getting set/used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
