gemini-code-assist[bot] commented on PR #36538: URL: https://github.com/apache/beam/pull/36538#issuecomment-3411169637
## Summary of Changes Hello @shunping, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the logging infrastructure within the Go SDK by centralizing structural logging configuration into a new dedicated internal package. This change improves modularity and maintainability, allowing for more consistent and configurable logging across different components, particularly for the Prism runner, which can now be initialized with specific log levels and kinds. ### Highlights * **Centralized Logging Configuration**: The structural logging configuration functions, previously in `pkg/beam/log`, have been moved to a new internal package, `pkg/beam/internal/logconfig`. This centralizes the logic for setting up `slog` with various levels and formats. * **Prism Runner Logging Options**: The Prism runner now accepts `LogLevel` and `LogKind` as explicit options when creating a Prism server. This allows users to dynamically configure the logging behavior of the Prism runner at startup. * **Simplified `pkg/beam/log` Package**: The `pkg/beam/log` package has been streamlined by removing its structural logging setup responsibilities and related imports. It now focuses on providing a core logging interface, delegating configuration to the new `logconfig` package. * **Consistent Logging Initialization**: Both the Go SDK's `pkg/beam/forward.go` and the Prism runner's `pkg/beam/runners/prism` now consistently utilize the new `pkg/beam/internal/logconfig` package for initializing their logging, ensuring a unified approach. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
